Make org.bouncycastle.jce.provider.BouncyCastleProvider optional by deferring initialization (#15756)#15788
Merged
Merged
Conversation
…eferring initialization (netty#15756) Motivation: Initialization of the `Algorithms` class causes `java.lang.ClassNotFoundException` if `org.bouncycastle.jce.provider.BouncyCastleProvider` is not present on the classpath. ``` Caused by: java.lang.ClassNotFoundException: org.bouncycastle.jce.provider.BouncyCastleProvider at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490) ... 6 more ``` Follow up to netty#15734 Modification: Make `org.bouncycastle.jce.provider.BouncyCastleProvider` optional by deferring initialization. Result: In case the `CertificateBuilder` is configured with custom `provider` instance, `org.bouncycastle.jce.provider.BouncyCastleProvider` will never be initialized. If there is no issue then describe the changes introduced by this PR. Signed-off-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 81ac843)
reta
approved these changes
Oct 24, 2025
normanmaurer
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Initialization of the
Algorithmsclass causesjava.lang.ClassNotFoundExceptioniforg.bouncycastle.jce.provider.BouncyCastleProvideris not present on the classpath.Follow up to #15734
Modification:
Make
org.bouncycastle.jce.provider.BouncyCastleProvideroptional by deferring initialization.Result:
In case the
CertificateBuilderis configured with customproviderinstance,org.bouncycastle.jce.provider.BouncyCastleProviderwill never be initialized.If there is no issue then describe the changes introduced by this PR.
(cherry picked from commit 81ac843)