Ensure Arena.ofShared() is usable before assuming that we can use Are…#15877
Merged
Conversation
…nas on JDK25 Motivation: Arena.ofShared() is disabled by default on GraalVM 25.0.0 so we can't assume that we can use it by default. Modifications: Try to use ofShared() and if it fails don't use Arena's at all Result: Fixes #15762
normanmaurer
added
the
needs-cherry-pick-5.0
yawkat
approved these changes
Nov 18, 2025
franz1981
approved these changes
Nov 18, 2025
adamdickmeiss
added a commit
to indexdata/reservoir
that referenced
this pull request
Dec 16, 2025
It is longer needed netty/netty#15877 which was fixed in Netty 4.2.8 release.
adamdickmeiss
added a commit
to indexdata/reservoir
that referenced
this pull request
Dec 16, 2025
It is longer needed netty/netty#15877 which was fixed in Netty 4.2.8 release.
This was referenced Dec 22, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nas on JDK25
Motivation:
Arena.ofShared() is disabled by default on GraalVM 25.0.0 so we can't assume that we can use it by default.
Modifications:
Try to use ofShared() and if it fails don't use Arena's at all
Result:
Fixes #15762