Recycler should not use thread locals unless they get cleaned up#16315
Merged
Conversation
Motivation: The Recycler is used for a lot of resources, such as ByteBuf and PoolThreadCache, that rely on GC effects or reference processing. These effects can be greatly delayed if thread local references aren't cleared when threads terminate. Modification: Instead of checking whether FastThreadLocals are _supported_ by the current thread, the Recycler now instead checks if thread locals are _cleaned_. The cleaning of thread locals is the effect we really care about. Result: Code, test and production alike, that rely on the timeliness of these effects become more deterministic.
chrisvest
added
needs-cherry-pick-4.1
Member
Author
|
This PR needs #16314 to be merged first, before the Recycler test suite will pass. |
netty-project-bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
) Motivation: The Recycler is used for a lot of resources, such as ByteBuf and PoolThreadCache, that rely on GC effects or reference processing. These effects can be greatly delayed if thread local references aren't cleared when threads terminate. Modification: Instead of checking whether FastThreadLocals are _supported_ by the current thread, the Recycler now instead checks if thread locals are _cleaned_. The cleaning of thread locals is the effect we really care about. Result: Code, test and production alike, that rely on the timeliness of these effects become more deterministic. Co-authored-by: Norman Maurer <norman_maurer@apple.com> (cherry picked from commit 77e2a68)
Contributor
|
Auto-port PR for 5.0: #16335 |
Contributor
|
Could not create auto-port PR. |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
chrisvest
added a commit
that referenced
this pull request
Feb 23, 2026
…cleaned up (#16335) Auto-port of #16315 to 5.0 Cherry-picked commit: 77e2a68 --- Motivation: The Recycler is used for a lot of resources, such as ByteBuf and PoolThreadCache, that rely on GC effects or reference processing. These effects can be greatly delayed if thread local references aren't cleared when threads terminate. Modification: Instead of checking whether FastThreadLocals are _supported_ by the current thread, the Recycler now instead checks if thread locals are _cleaned_. The cleaning of thread locals is the effect we really care about. Result: Code, test and production alike, that rely on the timeliness of these effects become more deterministic. Co-authored-by: Chris Vest <christianvest_hansen@apple.com> Co-authored-by: Norman Maurer <norman_maurer@apple.com>
chrisvest
removed
the
needs-cherry-pick-4.1
Member
Author
|
Quite a lot of changes to the Recycler between 4.1 and 4.2, so I don't think it make sense to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The Recycler is used for a lot of resources, such as ByteBuf and PoolThreadCache, that rely on GC effects or reference processing. These effects can be greatly delayed if thread local references aren't cleared when threads terminate.
Modification:
Instead of checking whether FastThreadLocals are supported by the current thread, the Recycler now instead checks if thread locals are cleaned. The cleaning of thread locals is the effect we really care about.
Result:
Code, test and production alike, that rely on the timeliness of these effects become more deterministic.