IoUring: Don't use RDHUP for non stream Channel implementations#16345
Merged
Conversation
normanmaurer
added
needs-cherry-pick-4.1
Member
Author
|
This actually did uncover an io_uring bug... looking into it now |
Motivation: We did not have any testing that ensured that it is actually possible to connect a DatagramChannel again after it was disconnected. Modifications: - Fix IoUring to only register RDHUP for stream channels and so fix assert error - Adjust testcase to cover this scenario Result: More complete testing of DatagramChannel implementations and fix for IoUring
normanmaurer
force-pushed
the
reconnect_test
branch
from
4a2bb0c to
4319208
Compare
normanmaurer
changed the title
normanmaurer
removed
the
needs-cherry-pick-4.1
Contributor
|
Could not create auto-port PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We did not have any testing that ensured that it is actually possible to connect a DatagramChannel again after it was disconnected.
Modifications:
Result:
More complete testing of DatagramChannel implementations and fix for IoUring