IoUring: Fix buffer leak in DatagramChannel implementation when recv …#16359
Merged
Conversation
…operation fails Motivation: We need to correctly release previously allocated read buffer in case of a failing recv operation. Not doing so will result in a buffer leak. Modifications: - Add assert to ensure the read buffer is deallocated before we finally unregister the IoUringHandle. - Correctly handle recv failures and so also release the read buffer in this case. Result: No more buffer leak in IoUringDatagramChannel
normanmaurer
added
the
needs-cherry-pick-5.0
Member
Author
|
/cc @dreamlike-ocean |
chrisvest
approved these changes
Feb 25, 2026
This was referenced Feb 25, 2026
Contributor
|
Could not create auto-port PR. |
normanmaurer
added a commit
that referenced
this pull request
Feb 25, 2026
#16359) …operation fails Motivation: We need to correctly release previously allocated read buffer in case of a failing recv operation. Not doing so will result in a buffer leak. Modifications: - Add assert to ensure the read buffer is deallocated before we finally unregister the IoUringHandle. - Correctly handle recv failures and so also release the read buffer in this case. Result: No more buffer leak in IoUringDatagramChannel
normanmaurer
added a commit
that referenced
this pull request
Feb 26, 2026
#16359) (#16363) …operation fails Motivation: We need to correctly release previously allocated read buffer in case of a failing recv operation. Not doing so will result in a buffer leak. Modifications: - Add assert to ensure the read buffer is deallocated before we finally unregister the IoUringHandle. - Correctly handle recv failures and so also release the read buffer in this case. Result: No more buffer leak in IoUringDatagramChannel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…operation fails
Motivation:
We need to correctly release previously allocated read buffer in case of a failing recv operation. Not doing so will result in a buffer leak.
Modifications:
Result:
No more buffer leak in IoUringDatagramChannel