Native transports: Fix undefined behaviour when GetStringUTFChars fails while open FD#16450
Merged
Conversation
…ls while open FD Motivation: We need to handle the case of GetStringUTFChars returning NULL as otherwise we run into undefined behavior which will most likely cause a crash Modifications: Return -ENOMEM in case of failure Result: No more undef behavior
normanmaurer
added
needs-cherry-pick-4.1
chrisvest
approved these changes
Mar 12, 2026
Contributor
|
Auto-port PR for 4.1: #16456 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
Contributor
|
Auto-port PR for 5.0: #16457 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
added a commit
that referenced
this pull request
Mar 13, 2026
…ingUTFChars fails while open FD (#16457) Auto-port of #16450 to 5.0 Cherry-picked commit: 8996631 --- Motivation: We need to handle the case of GetStringUTFChars returning NULL as otherwise we run into undefined behavior which will most likely cause a crash Modifications: Return -ENOMEM in case of failure Result: No more undef behavior Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Mar 13, 2026
…ingUTFChars fails while open FD (#16456) Auto-port of #16450 to 4.1 Cherry-picked commit: 8996631 --- Motivation: We need to handle the case of GetStringUTFChars returning NULL as otherwise we run into undefined behavior which will most likely cause a crash Modifications: Return -ENOMEM in case of failure Result: No more undef behavior Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to handle the case of GetStringUTFChars returning NULL as otherwise we run into undefined behavior which will most likely cause a crash
Modifications:
Return -ENOMEM in case of failure
Result:
No more undef behavior