Epoll: Add null checks for safety reasons#16454
Merged
Merged
Conversation
Motivation: We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone. Modifications: Add NULL check Result: More correct code
normanmaurer
added
needs-cherry-pick-4.1
Member
Author
|
This is just some "cleanup" to make the code more robust. |
chrisvest
approved these changes
Mar 13, 2026
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Motivation: We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone. Modifications: Add NULL check Result: More correct code (cherry picked from commit 342c1c0)
Contributor
|
Auto-port PR for 5.0: #16462 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Motivation: We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone. Modifications: Add NULL check Result: More correct code (cherry picked from commit 342c1c0)
Contributor
|
Auto-port PR for 4.1: #16463 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
chrisvest
pushed a commit
that referenced
this pull request
Mar 13, 2026
Auto-port of #16454 to 4.1 Cherry-picked commit: 342c1c0 --- Motivation: We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone. Modifications: Add NULL check Result: More correct code Co-authored-by: Norman Maurer <norman_maurer@apple.com>
chrisvest
pushed a commit
that referenced
this pull request
Mar 14, 2026
Auto-port of #16454 to 5.0 Cherry-picked commit: 342c1c0 --- Motivation: We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone. Modifications: Add NULL check Result: More correct code Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We did not check for NULL when calling GetObjectArrayElement which could be returned if we try to access an element that is out of bounds. While this should never happen we should better still guard against it to make the code less error-prone.
Modifications:
Add NULL check
Result:
More correct code