Epoll: Fix support for IP_RECVORIGDSTADDR#16461
Merged
Merged
Conversation
Motivation: We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg. Modifications: - Correctly use the return value and also validate that the socket option is actually set before allocating the control message buffer. Result: Fix support of IP_RECVORIGDSTADDR when using recvmmsg
normanmaurer
added
needs-cherry-pick-4.1
chrisvest
reviewed
Mar 13, 2026
Member
Author
Will check these one by one and open a PR if there are more problems. Let me merge this one first. |
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
Motivation: We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg. Modifications: - Correctly use the return value and also validate that the socket option is actually set before allocating the control message buffer. Result: Fix support of IP_RECVORIGDSTADDR when using recvmmsg (cherry picked from commit d97f5e6)
Contributor
|
Auto-port PR for 4.1: #16468 |
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
Motivation: We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg. Modifications: - Correctly use the return value and also validate that the socket option is actually set before allocating the control message buffer. Result: Fix support of IP_RECVORIGDSTADDR when using recvmmsg (cherry picked from commit d97f5e6)
Contributor
|
Auto-port PR for 5.0: #16469 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
added a commit
that referenced
this pull request
Mar 16, 2026
Auto-port of #16461 to 5.0 Cherry-picked commit: d97f5e6 --- Motivation: We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg. Modifications: - Correctly use the return value and also validate that the socket option is actually set before allocating the control message buffer. Result: Fix support of IP_RECVORIGDSTADDR when using recvmmsg Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Mar 16, 2026
Auto-port of #16461 to 4.1 Cherry-picked commit: d97f5e6 --- Motivation: We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg. Modifications: - Correctly use the return value and also validate that the socket option is actually set before allocating the control message buffer. Result: Fix support of IP_RECVORIGDSTADDR when using recvmmsg Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Member
Author
This is correct as we want to handle the error case here...
This one is correct as well.
Correct as netty_unix_socket_getOption will throw if < 0
Correct as netty_unix_socket_getOption will throw if < 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We incorrectly used the return value of netty_unix_socket_getOption(...,IP_RECVORIGDSTADDR) and so did not correctly support IP_RECVORIGDSTADDR when using recvmmsg.
Modifications:
Result:
Fix support of IP_RECVORIGDSTADDR when using recvmmsg