Quic: Fix global reference leak#16480
Merged
Merged
Conversation
Motivation: We did check the wrong variable for NULL and so leaked a global reference which means it can never be GC'ed. As this per QuicheQuicSslContext it is not super critical but still we shouldn't leak memory. Modifications: Fix NULL check Result: No more global reference leak
normanmaurer
added
the
needs-cherry-pick-5.0
chrisvest
approved these changes
Mar 17, 2026
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Motivation: We did check the wrong variable for NULL and so leaked a global reference which means it can never be GC'ed. As this per QuicheQuicSslContext it is not super critical but still we shouldn't leak memory. Modifications: Fix NULL check Result: No more global reference leak (cherry picked from commit 4b046fc)
Contributor
|
Auto-port PR for 5.0: #16495 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
added a commit
that referenced
this pull request
Mar 17, 2026
Auto-port of #16480 to 5.0 Cherry-picked commit: 4b046fc --- Motivation: We did check the wrong variable for NULL and so leaked a global reference which means it can never be GC'ed. As this per QuicheQuicSslContext it is not super critical but still we shouldn't leak memory. Modifications: Fix NULL check Result: No more global reference leak Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We did check the wrong variable for NULL and so leaked a global reference which means it can never be GC'ed. As this per QuicheQuicSslContext it is not super critical but still we shouldn't leak memory.
Modifications:
Fix NULL check
Result:
No more global reference leak