Conversation
Motivation: io_uring_mmap() returns -errno on failure so we need to negating it Modifications: - Changed ret to -ret Result: Since io_uring_mmap() returns -errno on failure, negating it recovers the positive errno value that throwRuntimeExceptionErrorNo expects for a meaningful error message.
normanmaurer
added
the
needs-cherry-pick-5.0
chrisvest
approved these changes
Mar 17, 2026
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Motivation: io_uring_mmap() returns -errno on failure so we need to negating it Modifications: - Changed ret to -ret Result: Since io_uring_mmap() returns -errno on failure, negating it recovers the positive errno value that throwRuntimeExceptionErrorNo expects for a meaningful error message. (cherry picked from commit 48162ce)
Contributor
|
Auto-port PR for 5.0: #16515 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
chrisvest
pushed a commit
that referenced
this pull request
Mar 18, 2026
Auto-port of #16500 to 5.0 Cherry-picked commit: 48162ce --- Motivation: io_uring_mmap() returns -errno on failure so we need to negating it Modifications: - Changed ret to -ret Result: Since io_uring_mmap() returns -errno on failure, negating it recovers the positive errno value that throwRuntimeExceptionErrorNo expects for a meaningful error message. Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
io_uring_mmap() returns -errno on failure so we need to negating it
Modifications:
Result:
Since io_uring_mmap() returns -errno on failure, negating it recovers the positive errno value that throwRuntimeExceptionErrorNo expects for a meaningful error message.