Replace ClosedChannelException with StacklessClosedChannelException#16506
Merged
normanmaurer merged 2 commits intoMar 18, 2026
Merged
Conversation
Member
|
This make sense... The only downside is that we now need to expose this as public. Not a big deal tho. |
chrisvest
reviewed
Mar 17, 2026
normanmaurer
added
the
needs-cherry-pick-5.0
Contributor
|
Could not create auto-port PR. |
normanmaurer
pushed a commit
that referenced
this pull request
Mar 18, 2026
…n` (#16506) Motivation: `SslHandler.channelInactive` allocates `ClosedChannelException`, which collects the stacktrace. In a high-load environment, with a large number of connections being opened/closed, this introduces GC pressure: <img width="1349" height="315" alt="Image" src="https://github.com/user-attachments/assets/7d578905-e74c-4fd2-81c6-2af1083ece5b" /> Modification: Replaced this exception with `StacklessClosedChannelException`, which will reduce pressure by eliminating the allocation of the `StackTraceElement[]` array for the stack trace. Result: Fixes #16504.
normanmaurer
pushed a commit
that referenced
this pull request
Mar 18, 2026
…n` (#16506) Motivation: `SslHandler.channelInactive` allocates `ClosedChannelException`, which collects the stacktrace. In a high-load environment, with a large number of connections being opened/closed, this introduces GC pressure: <img width="1349" height="315" alt="Image" src="https://github.com/user-attachments/assets/7d578905-e74c-4fd2-81c6-2af1083ece5b" /> Modification: Replaced this exception with `StacklessClosedChannelException`, which will reduce pressure by eliminating the allocation of the `StackTraceElement[]` array for the stack trace. Result: Fixes #16504.
normanmaurer
added a commit
that referenced
this pull request
Mar 18, 2026
…n` (#16506) (#16524) Motivation: `SslHandler.channelInactive` allocates `ClosedChannelException`, which collects the stacktrace. In a high-load environment, with a large number of connections being opened/closed, this introduces GC pressure: <img width="1349" height="315" alt="Image" src="https://github.com/user-attachments/assets/7d578905-e74c-4fd2-81c6-2af1083ece5b" /> Modification: Replaced this exception with `StacklessClosedChannelException`, which will reduce pressure by eliminating the allocation of the `StackTraceElement[]` array for the stack trace. Result: Fixes #16504. Co-authored-by: Nikita Ivchenko <munoongg@gmail.com>
chrisvest
removed
the
needs-cherry-pick-5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
SslHandler.channelInactiveallocatesClosedChannelException, which collects the stacktrace.In a high-load environment, with a large number of connections being opened/closed, this introduces GC pressure:
Modification:
Replaced this exception with
StacklessClosedChannelException, which will reduce pressure by eliminating the allocation of theStackTraceElement[]array for the stack trace.Result:
Fixes #16504.