IoUring: Add NULL check for GetStringUTFChars(...)#16509
Merged
Conversation
Motivation: We need to check if NULL is returned by GetStringUTFChars(...) as otherwise we might call open(...) with NULL which is undefined behavior Modifications: Add NULL check Result: No undefined behavior
normanmaurer
added
the
needs-cherry-pick-5.0
chrisvest
approved these changes
Mar 17, 2026
Contributor
|
Auto-port PR for 5.0: #16518 |
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Motivation: We need to check if NULL is returned by GetStringUTFChars(...) as otherwise we might call open(...) with NULL which is undefined behavior Modifications: Add NULL check Result: No undefined behavior (cherry picked from commit 1f7f5c9)
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
added a commit
that referenced
this pull request
Mar 18, 2026
…6518) Auto-port of #16509 to 5.0 Cherry-picked commit: 1f7f5c9 --- Motivation: We need to check if NULL is returned by GetStringUTFChars(...) as otherwise we might call open(...) with NULL which is undefined behavior Modifications: Add NULL check Result: No undefined behavior Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to check if NULL is returned by GetStringUTFChars(...) as otherwise we might call open(...) with NULL which is undefined behavior
Modifications:
Add NULL check
Result:
No undefined behavior