Fill MsgHdrMemoryArray#hdrs with null entry on release#16764
Merged
Conversation
normanmaurer
requested changes
May 7, 2026
Motivation: See netty#16763 This gives GC a chance to collect entries early. Calling release on each entry is effectively a no-op. Modifications: In MsgHdrMemoryArray#release, fill hdrs array with nulls instead of invoking release on every entry. #Result: After the instance is release, the GC can collect entries (about 600kb on my machine) early.
normanmaurer
added
the
needs-cherry-pick-5.0
normanmaurer
requested changes
May 7, 2026
…/MsgHdrMemoryArrayTest.java
Contributor
|
Auto-port PR for 5.0: #16771 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
added a commit
that referenced
this pull request
May 10, 2026
…#16771) Auto-port of #16764 to 5.0 Cherry-picked commit: 27ca159 --- Motivation: See #16763 This gives GC a chance to collect entries early. Calling release on each entry is effectively a no-op. Modifications: In MsgHdrMemoryArray#release, fill hdrs array with nulls instead of invoking release on every entry. Result: After the instance is release, the GC can collect entries (about 600kb on my machine) early. Co-authored-by: Thomas Segismont <tsegismo@ibm.com> Co-authored-by: Norman Maurer <norman_maurer@apple.com> Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
See #16763
This gives GC a chance to collect entries early.
Calling release on each entry is effectively a no-op.
Modifications:
In MsgHdrMemoryArray#release, fill hdrs array with nulls instead of invoking release on every entry.
Result:
After the instance is release, the GC can collect entries (about 600kb on my machine) early.