Auto-port 4.1: Add opt-in validation of mandatory pseudo-header fields for HTTP/2#16964
Merged
Conversation
…16932) Motivation: RFC 9113 Section 8.3 requires HTTP/2 requests to include `:method`, `:scheme` and `:path`, and responses to include `:status`. Netty's message API (HttpConversionUtil) already rejects a missing :method, :path or :status, but the raw frame API (Http2FrameCodec / Http2MultiplexHandler) does not validate this and accepts requests and responses with missing required pseudo-headers. This is reported in #10633 and #13630. Modification: Add an optional `validateRequiredPseudoHeaders` setting (disabled by default) to `DefaultHttp2ConnectionDecoder` and the HTTP/2 builders. When enabled, initial request and response HEADERS that omit a required pseudo-header are rejected with a `PROTOCOL_ERROR` stream error. `CONNECT` and extended `CONNECT` requests are handled according to RFC 9113 Section 8.5 and RFC 8441. Result: The raw frame API can now opt into RFC 9113 Section 8.3 required-pseudo-header validation, while preserving existing behavior by default. (cherry picked from commit 91ec8cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16932 to 4.1
Cherry-picked commit: 91ec8cd
Motivation:
RFC 9113 Section 8.3 requires HTTP/2 requests to include
:method,:schemeand:path, and responses to include:status. Netty's message API (HttpConversionUtil) already rejects a missing :method, :path or :status, but the raw frame API(Http2FrameCodec / Http2MultiplexHandler) does not validate this and accepts requests and responses with missing required pseudo-headers.
This is reported in #10633 and #13630.
Modification:
Add an optional
validateRequiredPseudoHeaderssetting (disabled by default) toDefaultHttp2ConnectionDecoderand the HTTP/2 builders. When enabled, initial request and response HEADERS that omit a required pseudo-header are rejected witha
PROTOCOL_ERRORstream error.CONNECTand extendedCONNECTrequests are handled according to RFC 9113 Section 8.5 and RFC 8441.Result:
The raw frame API can now opt into RFC 9113 Section 8.3 required-pseudo-header
validation, while preserving existing behavior by default.