Skip to content

Propagate the CI envionment variables through to the docker builds - #17138

Merged
chrisvest merged 1 commit into
netty:4.2from
chrisvest:4.2-propagate-ci-env-var
Jul 24, 2026
Merged

Propagate the CI envionment variables through to the docker builds#17138
chrisvest merged 1 commit into
netty:4.2from
chrisvest:4.2-propagate-ci-env-var

Conversation

@chrisvest

Copy link
Copy Markdown
Member

Motivation:
TestLens requires this in order to activate its profile. It's possible some of our other tools, e.g. sdkman also make use of this.

Modification:
Add CI to the environments in our docker-compose files.

Result:
We should now get testlens results from our docker-based linux builds.

Motivation:
TestLens requires this in order to activate its profile.
It's possible some of our other tools, e.g. sdkman also make use of this.

Modification:
Add `CI` to the environments in our docker-compose files.

Result:
We should now get testlens results from our docker-based linux builds.
@chrisvest chrisvest added this to the 4.2.17.Final milestone Jul 24, 2026
@chrisvest chrisvest added needs-cherry-pick-4.1 This PR should be cherry-picked to 4.1 once merged. needs-cherry-pick-5.0 This PR should be cherry-picked to 5.0 once merged. labels Jul 24, 2026
@testlens-app

testlens-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: e737e1b
▶️ Tests: 40912 executed
⚪️ Checks: 22/22 completed


Learn more about TestLens at testlens.app.

@chrisvest
chrisvest merged commit 6e8c31d into netty:4.2 Jul 24, 2026
23 checks passed
@netty-project-bot

Copy link
Copy Markdown
Contributor

Auto-port PR for 5.0: #17139

@netty-project-bot

Copy link
Copy Markdown
Contributor

Could not create auto-port PR.
Got conflicts when cherry-picking onto 4.1.

@chrisvest
chrisvest deleted the 4.2-propagate-ci-env-var branch July 24, 2026 23:14
chrisvest added a commit that referenced this pull request Jul 25, 2026
…ocker builds (#17139)

Auto-port of #17138 to 5.0
Cherry-picked commit: 6e8c31d

---
Motivation:
TestLens requires this in order to activate its profile. It's possible
some of our other tools, e.g. sdkman also make use of this.

Modification:
Add `CI` to the environments in our docker-compose files.

Result:
We should now get testlens results from our docker-based linux builds.

Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
@chrisvest

Copy link
Copy Markdown
Member Author

4.1 port #17143

@chrisvest chrisvest removed the needs-cherry-pick-4.1 This PR should be cherry-picked to 4.1 once merged. label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants