Fix DefaultChannelId MAC address parsing bug#6147
Closed
Scottmitch wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@jo-kin - Please verify this fixes the issue. |
Member
|
@Scottmitch there must be something wrong... Please check: |
Scottmitch
force-pushed
the
mac_parse
branch
2 times, most recently
from
382bcc3 to
7adfaaa
Compare
Member
Author
|
@normanmaurer - issue should be fixed now. |
Member
There was a problem hiding this comment.
@Scottmitch just remove the @return as it is the same as what is stated already ?
Member
|
@Scottmitch just one comment.. otherwise LGTM |
Scottmitch
force-pushed
the
mac_parse
branch
from
7adfaaa to
065fc13
Compare
Member
|
@Scottmitch ship it |
Motivation: DefaultChannelId provides a regular expression which validates if a user provided MAC address is valid. This regular expression may allow invalid MAC addresses and also not allow valid MAC addresses. Modifications: - Introduce a MacAddressUtil#parseMac method which can parse and validate the MAC address at the same time. The regular expression check before hand is additional overhead if we have to parse the MAC address. Result: Fixes netty#6132.
Scottmitch
force-pushed
the
mac_parse
branch
from
065fc13 to
31db94e
Compare
Member
Author
|
4.1 (3d11334) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
DefaultChannelId provides a regular expression which validates if a user provided MAC address is valid. This regular expression may allow invalid MAC addresses and also not allow valid MAC addresses.
Modifications:
Result:
Fixes #6132.