FixedCompositeByteBuf should allow to access memoryAddress / array wh…#7773
Merged
Conversation
…en wrap a single buffer. Motivation: We should allow to access the memoryAddress / array of the FixedCompositeByteBuf when it only wraps a single ByteBuf. We do the same for CompositeByteBuf. Modifications: - Check how many buffers FixedCompositeByteBuf wraps and depending on it delegate the access to the memoryAddress / array - Add unit tests. Result: Fixes [#7752].
Member
Author
|
Also @ldaley |
carl-mastrangelo
approved these changes
Mar 10, 2018
Member
carl-mastrangelo
left a comment
carl-mastrangelo
left a comment
There was a problem hiding this comment.
LGTM, looks pretty straightforward
Member
|
Was the branch |
Member
Author
|
@carl-mastrangelo nope... deleted. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…en wrap a single buffer.
Motivation:
We should allow to access the memoryAddress / array of the FixedCompositeByteBuf when it only wraps a single ByteBuf. We do the same for CompositeByteBuf.
Modifications:
Result:
Fixes [#7752].