Correctly take length of ByteBufInputStream into account for readLine…#9310
Merged
Conversation
…() / readByte() Motivation: ByteBufInputStream did not correctly take the length into account when validate bounds for readLine() / readByte() which could lead to read more then allowed. Modifications: - Correctly take length into account - Add unit tests - Fix existing unit test Result: Correctly take length of ByteBufInputStream into account. Related to #9306.
Member
Author
|
/cc @xiaoheng1 this is related to the issue you fixed . |
franz1981
approved these changes
Jul 1, 2019
normanmaurer
added a commit
that referenced
this pull request
Jul 1, 2019
#9310) * Correctly take length of ByteBufInputStream into account for readLine() / readByte() Motivation: ByteBufInputStream did not correctly take the length into account when validate bounds for readLine() / readByte() which could lead to read more then allowed. Modifications: - Correctly take length into account - Add unit tests - Fix existing unit test Result: Correctly take length of ByteBufInputStream into account. Related to #9306.
njhill
reviewed
Jul 1, 2019
Member
njhill
left a comment
njhill
left a comment
There was a problem hiding this comment.
LGTM just an optional nit which I guess applies to the read() method too
| public byte readByte() throws IOException { | ||
| if (!buffer.isReadable()) { | ||
| int available = available(); | ||
| if (available == 0) { |
Member
Author
There was a problem hiding this comment.
just because it was like this in other methods as well. So I felt it would be better to keep it consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…() / readByte()
Motivation:
ByteBufInputStream did not correctly take the length into account when validate bounds for readLine() / readByte() which could lead to read more then allowed.
Modifications:
Result:
Correctly take length of ByteBufInputStream into account.
Related to #9306.