fix One-Click Postage to work on pop out video player and Tumblr radar#582
fix One-Click Postage to work on pop out video player and Tumblr radar#582finagle29 wants to merge 4 commits intonew-xkit:masterfrom
Conversation
|
☔ The latest upstream changes (presumably #718) made this pull request unmergeable. Please resolve the merge conflicts. |
finagle29
force-pushed
the
floating-video_interface-post_fix
branch
from
a3991e9 to
9be20b6
Compare
finagle29
force-pushed
the
floating-video_interface-post_fix
branch
from
9be20b6 to
ed66311
Compare
|
☔ The latest upstream changes (presumably #832) made this pull request unmergeable. Please resolve the merge conflicts. |
finagle29
force-pushed
the
floating-video_interface-post_fix
branch
from
ed66311 to
cde8367
Compare
Extensions/xkit_patches.js
Outdated
| post: function(obj) { | ||
|
|
||
| var m_return = {}; | ||
| var post_data = JSON.parse($(obj).attr('data-json')); |
There was a problem hiding this comment.
I'd prefer this to have a fallback like line 1073 above where it's JSON.parse(asdf || "{}"). This would make the following if-statement detect the error where 'data-json' is undefined instead of having the parse throw an uncaught exception.
|
Pushed a commit that address review comments. |
|
☔ The latest upstream changes (presumably #973) made this pull request unmergeable. Please resolve the merge conflicts. |
finagle29
force-pushed
the
floating-video_interface-post_fix
branch
from
5a474b3 to
68141d9
Compare
|
☔ The latest upstream changes (presumably #1024) made this pull request unmergeable. Please resolve the merge conflicts. |
4 participants
fixes #575