fix: do not re-enable disabled default reminders because of legacy default reminder settings

[odzhychko]

Resolves #8816

Given

• php occ user:setting <userId> calendar defaultReminder 0
• 

Before

After

[odzhychko]

/backport to stable6.6

[odzhychko]

/backport to stable6.5

[SebastianKrupinski]

This should be a database migration not a work around

[odzhychko]

This should be a database migration not a work around

Looking at the existing code it seemed like we wanted to support default_reminder state for some reason. But I don't know why 🤷‍♂️

calendar/src/views/Calendar.vue

Lines 335 to 336 in 9482d92

	defaultReminderPartDay: loadState('calendar', 'default_reminder_part_day', loadState('calendar', 'default_reminder')),
	defaultReminderFullDay: loadState('calendar', 'default_reminder_full_day', loadState('calendar', 'default_reminder')),

calendar/src/store/settings.js

Lines 36 to 39 in 9482d92

	defaultReminderPartDay: null,
	defaultReminderFullDay: null,
	// Legacy fallback for users that have not saved separate part/full-day defaults yet.
	defaultReminder: null,

[SebastianKrupinski]

Looking at the existing code it seemed like we wanted to support default_reminder state for some reason. But I don't know why 🤷‍♂️

It was just something that was missed originally.

I have a fix, give me a few min

[SebastianKrupinski]

Looking at the existing code it seemed like we wanted to support default_reminder state for some reason. But I don't know why 🤷‍♂️

Actually sorry, this was done because the alarm feature was NC34+ and we supported NC32+ in calendar.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[odzhychko]

Closing favor of #8818