fix: migrate defaultReminder properly - #8818
Open
SebastianKrupinski wants to merge 1 commit into
Open
Conversation
SebastianKrupinski
requested review from
GVodyanov and
tcitworld
as code owners
August 31, 2026 16:15
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/migrate-default-reminder-properly
branch
from
August 31, 2026 18:24
72cc139 to
2591f91
Compare
tcitworld
reviewed
Sep 1, 2026
| $result = $qb->executeQuery(); | ||
|
|
||
| $migrated = 0; | ||
| while ($row = $result->fetch()) { |
Contributor
Author
There was a problem hiding this comment.
Hey!
So in the current design we updated the preferences for each user one by one. Therefore I was just pulling one record at a time.
I thought about a chunked bulk update, but could decide on a deceive way to handle per-existing "defaultReminderPartDay" and "defaultReminderPartDay"
Maybe, I should revisit the idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary