fix: do not create OAuth client when setting up with OIDC auth method#1073
Merged
Conversation
saw-jan
force-pushed
the
backport/1049/release/3.1
branch
from
dc01af5 to
3c1d951
Compare
saw-jan
changed the title
…#1049) * fix: do not create oauth client during oidc setup Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: add phpunit tests Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * chore: add changelog entry Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix test data Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix psalm config Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix phpunit test Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
backport/1049/release/3.1
branch
from
3c1d951 to
b5e6bcb
Compare
saw-jan
requested review from
ba1ash,
dominic-braeunlein,
individual-it and
julien-nc
as code owners
PHP Code CoverageCoverage after merging backport/1049/release/3.1 into release/3.1 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
saw-jan
requested review from
Ashim-Stha,
Kharonus,
NobodysNightmare,
lindenthal,
nabim777,
psatyal and
wielinde
as code owners
Ashim-Stha
approved these changes
Jun 24, 2026
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #1049
WP: https://community.openproject.org/wp/NEX-634