ci/fix: delete user directory on status code 400 by nabim777 · Pull Request #1087 · nextcloud/integration_openproject

nabim777 · 2026-07-01T04:52:51Z

Description

This PR includes the following changes:

Removed the force remove option from the command.
Moved the user data directory deletion method from the after scenario step to the user creation method, and it is now triggered when user creation fails with a 400 status code.

Related Issue or Workpackage

Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file
only accepts pull requests related to open issues -->

Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

github-actions · 2026-07-10T03:51:52Z

JS Code Coverage

Coverage after merging fix-ci/api-test into master will be

92.53%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
bootstrap.js	0%	0%	0%	0%	1, 1, 10–12, 2–9
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
reference.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
utils.js	85.92%	33.33%	50%	87.59%	12–20, 23–32
src/api
endpoints.js	100%	100%	100%	100%
settings.js	59.09%	100%	0%	68.42%	10–11, 14–15, 18–19
src/components
AdminSettings.vue	96.05%	94.26%	96.08%	96.31%	448–453, 456–461, 527–528, 532–533, 536–537, 541–542, 552–557, 588–590, 609–611, 691–693, 727–729
ErrorLabel.vue	100%	100%	100%	100%
OAuthConnectButton.vue	85.82%	63.64%	100%	87.39%	49–56, 64–69, 72–76
PersonalSettings.vue	92.02%	95.65%	90%	91.71%	133–134, 144–149, 152–161
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormAuthMethod.vue	97.85%	93.75%	100%	98.12%	168, 222–224, 247–250
FormHeading.vue	100%	100%	100%	100%
FormOAuthSettings.vue	97.61%	96.15%	93.10%	98.10%	217, 248, 338, 360, 378–380, 402–404
FormOpenProjectHost.vue	98.87%	94.74%	100%	99.34%	167–169, 279
FormSSOSettings.vue	98.57%	97.18%	96.55%	98.91%	231–233, 242–243, 358–359
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	100%	100%	100%	100%
src/components/icons
ClippyIcon.vue	100%	100%	100%	100%
OpenProjectIcon.vue	100%	100%	100%	100%
src/components/settings
CheckBox.vue	100%	100%	100%	100%
ErrorNote.vue	100%	100%	100%	100%
SettingsTitle.vue	94.74%	80%	100%	95.35%	49–53
src/components/tab
EmptyContent.vue	97.98%	90.91%	100%	98.82%	102–103, 107–108
SearchInput.vue	95.31%	92.96%	94.74%	95.78%	138–139, 192, 203–208, 267–269, 285–287, 291–296
WorkPackage.vue	86.22%	73.17%	93.33%	87.58%	106–115, 128–130, 141–145, 155–157, 175–181, 219, 219–224, 224, 224–235, 80–81
src/constants
appID.js	100%	100%	100%	100%
links.js	100%	100%	100%	100%
messages.js	100%	100%	100%	100%
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
workpackageHelper.js	93.80%	93.10%	88.89%	94.24%	100–102, 23–27, 54, 54–56, 97–99
src/views
CreateWorkPackageModal.vue	94.18%	86.32%	90.48%	95.43%	367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
Dashboard.vue	92.96%	92.86%	82.61%	93.77%	120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
LinkMultipleFilesModal.vue	99.14%	97.56%	100%	99.32%	157–159
ProjectsTab.vue	94.95%	94.34%	93.75%	95.10%	104–107, 143, 154–155, 189–199, 248–250

github-actions · 2026-07-10T03:54:34Z

PHP Code Coverage

Coverage after merging fix-ci/api-test into master will be

67.90%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
OIDCClientMapper.php	0%	100%	0%	0%	29, 40–49, 52
ServerVersion.php	0%	100%	0%	0%	17, 27–29, 32, 41–42
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	36.59%	100%	50%	35.53%	115–117, 120–124, 126–131, 133–134, 137, 142–143, 145–148, 150, 152, 154, 158–161, 163–174, 176, 179, 183, 187–189, 222
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	79.01%	100%	70.59%	79.36%	114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 719, 722, 725–740, 754–757, 759–763
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	71.03%	100%	100%	70.21%	117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
FilesController.php	85.60%	100%	83.33%	85.71%	181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
OpenProjectAPIController.php	81.09%	100%	82.35%	80.98%	116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	100%	100%	100%	100%
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	0%	100%	0%	0%	30, 37–38, 40–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54
LoadSidebarScript.php	65.91%	100%	100%	64.29%	105, 77–88, 95, 98
OpenProjectReferenceListener.php	0%	100%	0%	0%	45–47, 54–55, 57, 59–60, 62–74
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version20100Date20250820101358.php	0%	100%	0%	0%	38, 47–53, 56
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
Version2900Date20250718065820.php	0%	100%	0%	0%	22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	0%	100%	0%	0%	100–101, 40–42, 51–58, 60–66, 75–83, 94–99

nabim777 · 2026-07-10T08:39:02Z

/backport 36c0e16 to release/3.1

* chore/ci: delete user directory on status code 400 Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * tests: check response content Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

nabim777 · 2026-07-10T08:40:48Z

/backport 36c0e16 to release/2.11

* chore/ci: delete user directory on status code 400 Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * tests: check response content Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

nabim777 self-assigned this Jul 1, 2026

nabim777 force-pushed the fix-ci/api-test branch 7 times, most recently from dcfb158 to 83286a6 Compare July 6, 2026 09:13

nabim777 force-pushed the fix-ci/api-test branch 2 times, most recently from cbbd5e6 to ae28970 Compare July 9, 2026 10:27

nabim777 changed the title ~~fix: remove force flag when deleting user data directory~~ ci/fix: delete user directory on status code 400 Jul 9, 2026

nabim777 force-pushed the fix-ci/api-test branch 2 times, most recently from d3856a2 to b01047a Compare July 9, 2026 10:30

chore/ci: delete user directory on status code 400

7b7c401

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

nabim777 force-pushed the fix-ci/api-test branch from b01047a to 7b7c401 Compare July 9, 2026 10:31

nabim777 marked this pull request as ready for review July 9, 2026 10:38

nabim777 requested review from Ashim-Stha, Kharonus, NobodysNightmare, ba1ash, dominic-braeunlein, individual-it, julien-nc, lindenthal, psatyal, saw-jan and wielinde as code owners July 9, 2026 10:38

saw-jan reviewed Jul 9, 2026

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/FeatureContext.php Outdated

saw-jan reviewed Jul 9, 2026

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/FeatureContext.php Outdated

nabim777 force-pushed the fix-ci/api-test branch from 5af1734 to 3f4672c Compare July 9, 2026 11:23

nabim777 requested a review from saw-jan July 9, 2026 11:26

saw-jan reviewed Jul 9, 2026

View reviewed changes

tests: check response content

c3142e5

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

nabim777 force-pushed the fix-ci/api-test branch from 3f4672c to c3142e5 Compare July 10, 2026 03:50

saw-jan approved these changes Jul 10, 2026

View reviewed changes

Ashim-Stha approved these changes Jul 10, 2026

View reviewed changes

nabim777 merged commit 36c0e16 into master Jul 10, 2026
10 checks passed

nabim777 deleted the fix-ci/api-test branch July 10, 2026 08:26

backportbot Bot added the backport-request label Jul 10, 2026

backportbot Bot mentioned this pull request Jul 10, 2026

[release/3.1] ci/fix: delete user directory on status code 400 (#1087) #1105

Open

backportbot Bot removed the backport-request label Jul 10, 2026

backportbot Bot added the backport-request label Jul 10, 2026

backportbot Bot mentioned this pull request Jul 10, 2026

[release/2.11] ci/fix: delete user directory on status code 400 (#1087) #1106

Open

backportbot Bot removed the backport-request label Jul 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci/fix: delete user directory on status code 400#1087

ci/fix: delete user directory on status code 400#1087
nabim777 merged 2 commits into
masterfrom
fix-ci/api-test

nabim777 commented Jul 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

Uh oh!

nabim777 commented Jul 10, 2026

Uh oh!

nabim777 commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nabim777 commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

Checklist:

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

JS Code Coverage

Uh oh!

github-actions Bot commented Jul 10, 2026

PHP Code Coverage

Uh oh!

Uh oh!

nabim777 commented Jul 10, 2026

Uh oh!

nabim777 commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nabim777 commented Jul 1, 2026 •

edited

Loading