Improve remote video playback reliability and VLC lifecycle handling - #4217
Merged
Conversation
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use an async AVFoundation playability check with cancellation and an eight-second VLC fallback timeout. Pass the user agent to video playback and bump the app version to 34.1.1. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Reset playback launch state when presentation is rejected and add VLC presentation and playback diagnostics. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve remote video playback reliability and prevent VLC lifecycle races when changing or closing videos.
Changes
Motivation
Remote videos could remain indefinitely in the loading state when the AVFoundation probe did not complete or when a VLC presentation request was rejected during a transition.
VLC could also continue accessing its rendering view while the player was being dismissed or another video was selected, potentially triggering an Auto Layout operation outside the main thread.
Testing
🤖 AI (if applicable)