Fixed open article in browser call#807
Merged
David-Development merged 1 commit intonextcloud:masterfrom Jan 5, 2020
emasty:fix_open_browser_behaviour
Merged
Fixed open article in browser call#807David-Development merged 1 commit intonextcloud:masterfrom emasty:fix_open_browser_behaviour
David-Development merged 1 commit intonextcloud:masterfrom
emasty:fix_open_browser_behaviour
Conversation
Opening an article in browser was handled differently in different views. - When a link was pressed in the webview showing the article, the users browser settings were considered and the correct browser opened - When a link was opened using the menu entry, the article was always loaded in Chrome custom tabs, independend of user settings. Both ways now use the same function and behaviour. Signed-off-by: emasty <emasty@gmail.com>
Member
|
Awesome, thank you! I noticed issues with it too but didn't have the time to look into it yet. Thank you for working on it! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an article in browser was handled differently in different views.
Both ways now use the same function and behaviour.