chore(deps): Bump dompurify from 3.4.11 to 3.4.12 - #82
Merged
Conversation
dependabot
Bot
added
dependencies
Contributor
|
@dependabot rebase |
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.11 to 3.4.12. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.11...3.4.12) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/dompurify-3.4.12
branch
from
August 3, 2026 13:06
fab6a74 to
4ea792f
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
moodyjmz
added a commit
that referenced
this pull request
Aug 3, 2026
The js/ build output is committed, and npm-build.yml fails when the working tree is dirty after a build. Every bundled-dependency bump therefore makes the committed assets stale, and the PR needs a /compile comment before it can go green. That cost is per-PR, and worse, every merge to a target branch invalidates the committed assets on all the other open PRs — so a backlog of N bumps is up to N sequential rebase/compile/merge cycles rather than N compiles. There are currently 17 open dependabot PRs across main and stable34. Group minor and patch updates so a week of bumps arrives as a handful of PRs rather than one per dependency. Each npm block gets three groups, and since groups are first-match the order matters: - npm-production and npm-development split direct dependencies, so a bundle regression is narrowed to one half rather than requiring a bisect across every dependency in a single PR, each attempt costing a /compile. - npm-other then catches everything the first two cannot. dependency-type covers direct dependencies only, and npm is not one of the ecosystems for which it extends to indirect ones, so without this group transitive bumps would keep arriving as individual PRs. That is not a marginal case: four of the ten currently open npm PRs on main are transitive (immutable, fast-uri, postcss, and axios, the last because the manifest declares @nextcloud/axios), and dompurify in #82 was too. Those bundled transitive runtime dependencies are exactly the ones that need a /compile. Majors stay ungrouped on main so they still get individual review; on stable34 the existing ignore rule already limits updates to patches. Also disable auto-rebase for npm. A rebase without a recompile leaves CI red regardless, so rebasing every open PR on each merge only burns CI runs across the whole queue. Composer keeps auto-rebase, since those PRs pass without a recompile. Adds a cooldown so rapid successive releases of the same dependency collapse into one update rather than one PR each. Cooldown applies to version updates only, so security updates are not delayed. This mirrors nextcloud/server, which commits its dist/ output and uses the same combination of groups, disabled npm rebasing and cooldown for the same reason. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dompurify from 3.4.11 to 3.4.12.
Release notes
Sourced from dompurify's releases.
Commits
a9ca1e5release: 3.4.12 (#1537)