feat: add UUIDs to columns#2598
Conversation
Would not implement it now as it is not required currently. If necessary for an auto-update of a table without specifying local ids, this can be always added alter on easily. |
|
I guess that uuid should be unique across table (we need add unique id for table_id+uuid). Here use-cases that we need to support: Table update between instance
Table duplocation a single NC instanceA second scenario is especially important for end users who do not have separate environments:
|
Yupp, this scenario is exactly what are having in mind.
This would also be covered, as importing always requires a target table. So having columns with the same UUID across different tables is intentional. Hence importing, so the plan, would only affect the columns on the targeted table. |
ae39c12 to
467b0d3
Compare
bfc9724 to
3c96380
Compare
|
@enjeck resolved all your comments. For you convenience, I have the essential changes still left in the unstashed fixup-PRs, and then there is just one additional commit. I would leave this now as the basework and would implement the create and update logic in a seperate PR. |
|
Locally, all Playwright tests pass… |
|
|
3b06d7d to
435004b
Compare
I am challenging my statement now, |
luka-nextcloud
left a comment
There was a problem hiding this comment.
@blizzz I have tested and it works great. I just have a minor comment.
|
Thx, rebased and squashed everything. |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Base for structural updates, cf. my comment in #2504 (comment)
Treat multiselection default on export and import