Skip to content

fix(editorApi): access Editor.vue component through Editor.js wrapper#8522

Merged
mejo- merged 2 commits intomainfrom
fix/editor_api_wrapper_component
Apr 28, 2026
Merged

fix(editorApi): access Editor.vue component through Editor.js wrapper#8522
mejo- merged 2 commits intomainfrom
fix/editor_api_wrapper_component

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Apr 28, 2026

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

mejo- added 2 commits April 28, 2026 10:51
Editor.vue already emits events from itself and the parent, so no need
to make the Editor.js wrapper component fire them again.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Apr 28, 2026
@mejo- mejo- requested a review from max-nextcloud as a code owner April 28, 2026 09:23
@mejo- mejo- requested a review from silverkszlo as a code owner April 28, 2026 09:23
@mejo- mejo- added bug Something isn't working 3. to review regression labels Apr 28, 2026
@mejo- mejo- moved this to 🏗️ In progress in 📝 Productivity team Apr 28, 2026
@mejo- mejo- moved this from 🏗️ In progress to 👀 In review in 📝 Productivity team Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mejo- mejo- merged commit f02a7cc into main Apr 28, 2026
62 of 64 checks passed
@mejo- mejo- deleted the fix/editor_api_wrapper_component branch April 28, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working regression

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants