Skip to content

fix(editorApi): access Editor.vue component through Editor.js wrapper #8522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 2 commits into from
Apr 28, 2026
+7 −5
Merged

fix(editorApi): access Editor.vue component through Editor.js wrapper #8522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95f4871
fix(editorApi): access Editor.vue component through Editor.js wrapper
mejo- Apr 28, 2026
c2983dd
fix(editor): don't double-fire events from Editor.vue
mejo- Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/components/Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { defineComponent, h, nextTick, ref, watch } from 'vue'
import Editor from './Editor.vue'

export default defineComponent({
emits: ['focus', 'ready', 'create:content', 'update:content'],
emits: ['focus'],
props: Editor.props,
setup(props, { attrs, emit, slots }) {
const reloading = ref(false)
Expand All @@ -25,10 +25,7 @@ export default defineComponent({
props,
on: {
focus: () => emit('focus'),
ready: () => emit('ready'),
reload: () => (reloading.value = true),
'create:content': (content) => emit('create:content', content),
'update:content': (content) => emit('update:content', content),
},
scopedSlots: slots,
})
Expand Down
7 changes: 6 additions & 1 deletion src/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ class TextEditorEmbed {
}

#getEditorComponent() {
return this.#vm.$children[0]
let component = this.#vm.$children[0]
// For session editors, there's an extra wrapper component before Editor.vue
if (component && !('editor' in component)) {
component = component.$children[0]
}
return component
}

onCreate(onCreateCallback = () => {}) {
Expand Down
Loading