fix(links): scroll to anchor links directly#8857
Merged
Merged
Conversation
Setting location.href doesn't work reliably as the window may hold several editors with conflicting IDs (e.g. reader and editor in Collectives). Instead, scroll to the heading in `view.dom`. Fixes: #8804 Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
5 tasks
Member
Author
|
nextcloud/collectives#2633 brings a regression test for this fix. |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable34 |
silverkszlo
approved these changes
Jul 13, 2026
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This was referenced Jul 13, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/8857/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f36ea641
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8857/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
Manual backport to stable32: #8868 |
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 13, 2026
- Migrate test to open page URL with heading anchor from Cypress - Add test to click on anchor link to current page (regression test for nextcloud/text#8857) Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
Jul 13, 2026
- Migrate test to open page URL with heading anchor from Cypress - Add test to click on anchor link to current page (regression test for nextcloud/text#8857) Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting location.href doesn't work reliably as the window may hold several editors with conflicting IDs (e.g. reader and editor in Collectives). Instead, scroll to the heading in
view.dom.Fixes: #8804
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)