Skip to content

fix: update ShowImageModal to use fullUrl for show original image ins… - #8924

Merged
mejo- merged 1 commit into
nextcloud:mainfrom
mosi-kha:patch-1
Aug 3, 2026
Merged

fix: update ShowImageModal to use fullUrl for show original image ins…#8924
mejo- merged 1 commit into
nextcloud:mainfrom
mosi-kha:patch-1

Conversation

@mosi-kha

Copy link
Copy Markdown
Contributor

📝 Summary

Clicking an embedded image opened the modal on currentImage.previewUrl — the
1024x1024 preview, upscaled to an 80vh modal and visibly soft. fullUrl (the
original, same route + &preferRawImage=1) was already on the attachment object
and unused, so this just points the modal's <img> at it.

Inline rendering is untouched — documents still load previews, the original is
fetched only on an explicit click. Also matches handleAttachmentClick(), which
already uses fullUrl / the Viewer; the image modal was the only click-through
still showing a preview.

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

…tead of preview

Signed-off-by: mostafa khaki <mostafakhaki00@gmail.com>

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good finding!

@mejo-

mejo- commented Aug 3, 2026

Copy link
Copy Markdown
Member

/backport to stable34

@mejo-

mejo- commented Aug 3, 2026

Copy link
Copy Markdown
Member

/backport to stable33

@mejo-

mejo- commented Aug 3, 2026

Copy link
Copy Markdown
Member

/backport to stable32

@mejo-
mejo- merged commit 7fd0553 into nextcloud:main Aug 3, 2026
61 checks passed
@backportbot

backportbot Bot commented Aug 3, 2026

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/8924/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 293206f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8924/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Aug 3, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/8924/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 293206f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8924/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Aug 3, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/8924/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 293206f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8924/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mejo-

mejo- commented Aug 3, 2026

Copy link
Copy Markdown
Member

Manual backports starting at #8946

@mejo- mejo- added bug Something isn't working papercut and removed backport-request labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working papercut

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants