[stable34] test(playwright): don't set webServer.url parameter - #8976
Merged
Conversation
We want Playwright to wait for the `webServer.wait.stdout` condition. If `webServer.url` is set, it takes precedence. Set `reuseExistingServer: false` and let `start-nextcloud-server.mjs` detect if the webserver is already running. With these changes, Playwright waits for Nextcloud to be ready before running the tests, but at the same time can be started several times in a row with a running Docker container without running into conflicts. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
mejo-
force-pushed
the
backport/8968/stable34
branch
from
August 5, 2026 08:24
200a5da to
14e6bf9
Compare
mejo-
marked this pull request as ready for review
August 5, 2026 08:25
mejo-
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8968
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.