Skip to content

Fix(LinkPicker): improve suggestions order and rename 'Files' - #9020

Merged
mejo- merged 3 commits into
mainfrom
fix/link_picker_ux
Aug 10, 2026
Merged

Fix(LinkPicker): improve suggestions order and rename 'Files'#9020
mejo- merged 3 commits into
mainfrom
fix/link_picker_ux

Conversation

@mejo-

@mejo- mejo- commented Aug 9, 2026

Copy link
Copy Markdown
Member

📝 Summary

  • List smart picker items with order === -1 first (e.g. "Link to page in collective" inside Collectives).
  • List some items declared as "important" second.
  • List remaining smart picker items third.
  • List remaining formatting items last.
  • Rename 'Files' to 'Link a file'. The generic 'Files' is too ambiguous in document editing context.
  • Resolves: Improve UX of "add menu" (especially for collectives) #8802

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

mejo- added 2 commits August 9, 2026 18:32
* List smart picker items with `order === -1` first (e.g. "Link
  to page in collective" inside Collectives)
* List some items declared as "important" second
* List remaining smart picker items third
* List remaining formatting items last

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5
The generic 'Files' is too ambiguous in document editing context.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo- force-pushed the fix/link_picker_ux branch from 8996dd7 to e4fae5c Compare August 9, 2026 16:42
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Aug 9, 2026

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one question.

Comment thread src/components/Suggestion/LinkPicker/suggestions.js
@mejo-
mejo- merged commit b9d1df4 into main Aug 10, 2026
61 checks passed
@mejo-
mejo- deleted the fix/link_picker_ux branch August 10, 2026 08:44
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Aug 10, 2026
@mejo-

mejo- commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-

mejo- commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Improve UX of "add menu" (especially for collectives)

2 participants