test(playwright): migrate propfind tests from Cypress to Playwright by mejo- · Pull Request #9021 · nextcloud/text

mejo- · 2026-08-09T21:21:34Z

Assisted-by: OpenCode:claude-fable-5

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

The content of this PR was partly generated using AI tools
The AI-generated content was reviewed, comprehended and tested by a human

mejo- · 2026-08-09T21:21:46Z

/backport to stable34

mejo- · 2026-08-09T21:22:08Z

/backport to stable33

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

mejo- · 2026-08-10T07:50:29Z

+			const [root1] = await propfindFolder(user, '/', 0, properties)
+			expect(root1).toHaveProperty(PROPERTY_WORKSPACE_FLAT, '')
+
+			await deleteWebDAVResource(user, '/Readme.md')


This line most likely fixes the flakiness of the test compared to the Cypress one. Without this line, this test succeeds reliably locally but fails reliably (so far) in CI.

Claude assumes that this is because the storage cache doesn't get invalidated properly in CI when only overwriting the file compared to deleting it and uploading a new file (which results in new fileId etc). It may well be that the missing cache invalidation is due to different APCu caching setup in CI.

I wonder if we could fix that different setup. Would such a setup have visible consequences in actual setups or is this a CI artifact we are observing?

I don't have hard feelings here. I didn't dive into investigating the actual differences with caching setup between CI and local environment, I merely was happy to have found an explanation for the flaky test and decided to move on 😆

@max-nextcloud do you see a problem with adding the delete in the test? It arguably changes what is being tested: updating a file no longer is tested. But do you think it should be tested in the propfind tests?

Well... this started out as a regression test. Would be interesting to see if this actually represents a user visible bug. So if one user creates an empty readme.md and then another one adds content... does the content show? I'll try.

So I tried this on cloud.nextcloud.com and it works as intended. However we may not have the problematic caching config and I think I remember that the propfind was also used by the desktop client.
In the browser it basically directly opens an editing session - editable or read only and dynamically syncs the content.

Yes... this initially was about android: nextcloud/server#32548 (comment)

I was hoping the backports would tell us if this is present in previous versions as well. But they do not work automatically.

test is passing in stable34 so this seems to be a recent regression.

The test was just being flaky. The underlying cause is that Etags will not be updated if the mtime does not change. So if the file was initially written in the same second the update happened the update will not be propagated.

This problem is specific to our test setup - as usually one does not update a file multiple times per second. I'll adjust the test to account for this.

…slow The test often exceeds the default timeout in CI. Signed-off-by: Jonas <jonas@freesources.org>

Signed-off-by: Max <max@nextcloud.com>

max-nextcloud · 2026-08-11T18:25:47Z

/backport! to stable34 please

max-nextcloud · 2026-08-11T18:25:54Z

/backport! to stable33 please

backportbot · 2026-08-11T18:26:08Z

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/9021/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b9c85053 86f6d68a bd5cc743

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9021/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Etags will not be updated if the mtime does not change. So if the file was overwritten within the same second it was created the mtime and the etag will remain the same and the outdated cached content will be distributed. This problem is specific to our test setup. Usually one does not update a file multiple times per second. Adjust the test to ensure the mtime changes. Signed-off-by: Max <max@nextcloud.com>

backportbot · 2026-08-13T09:53:53Z

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/9021/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b9c85053 86f6d68a bd5cc743 cb19d998

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9021/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot · 2026-08-13T09:53:59Z

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/9021/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b9c85053 86f6d68a bd5cc743 cb19d998

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9021/stable34

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/9021/stable34."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

mejo- · 2026-08-13T09:56:37Z

/backport to stable34

mejo- self-assigned this Aug 9, 2026

mejo- requested review from max-nextcloud and silverkszlo as code owners August 9, 2026 21:21

mejo- added the tests If you write them we ♥ you label Aug 9, 2026

mejo- added this to 📝 Productivity team Aug 9, 2026

mejo- added the 3. to review label Aug 9, 2026

github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Aug 9, 2026

backportbot Bot added the backport-request label Aug 9, 2026

test(playwright): migrate propfind tests from Cypress to Playwright

b9c8505

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

mejo- force-pushed the test/propfind_playwright branch from 0282101 to b9c8505 Compare August 10, 2026 07:35

mejo- commented Aug 10, 2026

View reviewed changes

mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Aug 10, 2026

mejo- and others added 2 commits August 11, 2026 14:58

test(playwright): Mark "conflict dialog is sticky when scrolling" as …

86f6d68

…slow The test often exceeds the default timeout in CI. Signed-off-by: Jonas <jonas@freesources.org>

chore(test): restore old test behavior

bd5cc74

Signed-off-by: Max <max@nextcloud.com>

backportbot Bot mentioned this pull request Aug 11, 2026

[stable34] test(playwright): migrate propfind tests from Cypress to Playwright #9035

Closed

3 tasks

backportbot Bot removed the backport-request label Aug 11, 2026

max-nextcloud approved these changes Aug 13, 2026

View reviewed changes

mejo- merged commit 4c9eb08 into main Aug 13, 2026
80 of 89 checks passed

mejo- deleted the test/propfind_playwright branch August 13, 2026 09:53

github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Aug 13, 2026

backportbot Bot added the backport-request label Aug 13, 2026

backportbot Bot mentioned this pull request Aug 13, 2026

[stable34] test(playwright): migrate propfind tests from Cypress to Playwright #9041

Open

3 tasks

backportbot Bot removed the backport-request label Aug 13, 2026

nextcloud-bot mentioned this pull request Aug 13, 2026

35.0.0 beta 2 nextcloud/server#63182

Merged

Uh oh!

Conversation

mejo- commented Aug 9, 2026

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

mejo- commented Aug 9, 2026

Uh oh!

mejo- commented Aug 9, 2026

Uh oh!

mejo- Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-nextcloud commented Aug 11, 2026

Uh oh!

max-nextcloud commented Aug 11, 2026

Uh oh!

backportbot Bot commented Aug 11, 2026

Uh oh!

Uh oh!

backportbot Bot commented Aug 13, 2026

Uh oh!

backportbot Bot commented Aug 13, 2026

Uh oh!

mejo- commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mejo- Aug 10, 2026 •

edited

Loading