Skip to content

fix(collaboration): override addProseMirrorPlugins to prevent default caret user - #9160

Merged
blizzz merged 1 commit into
mainfrom
fix/caret-user
Sep 2, 2026
Merged

fix(collaboration): override addProseMirrorPlugins to prevent default caret user#9160
blizzz merged 1 commit into
mainfrom
fix/caret-user

Conversation

@benjaminfrueh

@benjaminfrueh benjaminfrueh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📝 Summary

Fixes the collaborator cursor showing a id (e.g. User: 123) instead of the actual name in stable35.

What happened

Tiptap sets its own default user when the caret feature is setup. Since a recent tiptap update (>= 3.24.0), which we use now with stable35, this happens later and ends up overwriting the name we set.

Fix

Override tiptap's addProseMirrorPlugins in our caret extension so it no longer sets a default user, leaving our user data as the only source.

Related tiptap commit which introduced this incompatibility:
ueberdosis/tiptap@976b8e3

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

… caret user

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@benjaminfrueh benjaminfrueh added the bug Something isn't working label Sep 2, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Sep 2, 2026
@benjaminfrueh benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Sep 2, 2026
@benjaminfrueh

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

@blizzz
blizzz merged commit 846e572 into main Sep 2, 2026
74 of 81 checks passed
@blizzz
blizzz deleted the fix/caret-user branch September 2, 2026 20:47
@backportbot

backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/9160/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick deed5c59

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9160/stable35

Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: expected flush after ref listing


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Sep 2, 2026
@blizzz

blizzz commented Sep 2, 2026

Copy link
Copy Markdown
Member

/backport to stable35

@backportbot

backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/9160/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick deed5c59

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9160/stable35

Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: expected flush after ref listing


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants