fix(collaboration): override addProseMirrorPlugins to prevent default caret user - #9160
Conversation
… caret user Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
|
/backport to stable35 |
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes look good.
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/9160/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick deed5c59
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9160/stable35Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401 Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable35 |
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/9160/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick deed5c59
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9160/stable35Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401 Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
📝 Summary
Fixes the collaborator cursor showing a id (e.g.
User: 123) instead of the actual name in stable35.What happened
Tiptap sets its own default user when the caret feature is setup. Since a recent tiptap update (>= 3.24.0), which we use now with stable35, this happens later and ends up overwriting the name we set.
Fix
Override tiptap's
addProseMirrorPluginsin our caret extension so it no longer sets a default user, leaving our user data as the only source.Related tiptap commit which introduced this incompatibility:
ueberdosis/tiptap@976b8e3
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)