Skip to content

Update references to match RefSeq#23

Merged
trvrb merged 6 commits into
mainfrom
update-references-to-match-refseq
Aug 15, 2024
Merged

Update references to match RefSeq#23
trvrb merged 6 commits into
mainfrom
update-references-to-match-refseq

Conversation

@j23414
Copy link
Copy Markdown
Contributor

@j23414 j23414 commented Aug 12, 2024

Description of proposed changes

Switch to the RefSeq reference 'Josiah' for consistency.

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 changed the title Update references to match refseq Update references to match RefSeq Aug 12, 2024
@j23414
Copy link
Copy Markdown
Contributor Author

j23414 commented Aug 12, 2024

Hmm, realizing that updating the references in phylogenetic triggers concurrent changes to segment references for ingest

@j23414 j23414 marked this pull request as draft August 12, 2024 19:50
@j23414 j23414 force-pushed the update-references-to-match-refseq branch from 19b08cb to eeaf7b1 Compare August 15, 2024 16:05
@j23414 j23414 marked this pull request as ready for review August 15, 2024 16:34
@j23414
Copy link
Copy Markdown
Contributor Author

j23414 commented Aug 15, 2024

I've moved the updating segment reference files to a separate issue. The main changes in this PR are from this slack thread:

  1. Add Pinneo as explicit root
  2. Update reference to be Josiah

Which results in the following trees:

@trvrb trvrb self-requested a review August 15, 2024 19:12
Root to common ancestor of the outgroup clade that contains strains Pinneo-NIG-1969 and 812285. Also, make sure to always include these sequences when preparing sequence data.
@trvrb
Copy link
Copy Markdown
Member

trvrb commented Aug 15, 2024

Thanks for putting this together @j23414. In the above I just passed in two tips instead to specify a clade to root to. This isn't perfect, but is a bit less funky than TreeTime's behavior of placing root exactly on the specified tip.

Also, I added include.txt to make sure to always include these strains.

You can see resulting output here:

@trvrb
Copy link
Copy Markdown
Member

trvrb commented Aug 15, 2024

@j23414: Could you add MG812675 to the example data? This should make the CI complete.

@j23414
Copy link
Copy Markdown
Contributor Author

j23414 commented Aug 15, 2024

Thanks @trvrb! I was wondering how to get a more reasonable root of the trees

I've updated the example data in 6405c92

@trvrb trvrb merged commit a2b2262 into main Aug 15, 2024
@trvrb trvrb deleted the update-references-to-match-refseq branch August 15, 2024 23:23
@j23414 j23414 linked an issue Aug 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistently pick a reference strain for all builds

2 participants