Update references to match RefSeq#23
Merged
Merged
Conversation
Contributor
Author
|
Hmm, realizing that updating the references in phylogenetic triggers concurrent changes to segment references for ingest |
19b08cb to
eeaf7b1
Compare
Contributor
Author
|
I've moved the updating segment reference files to a separate issue. The main changes in this PR are from this slack thread:
Which results in the following trees: |
Root to common ancestor of the outgroup clade that contains strains Pinneo-NIG-1969 and 812285. Also, make sure to always include these sequences when preparing sequence data.
Member
|
Thanks for putting this together @j23414. In the above I just passed in two tips instead to specify a clade to root to. This isn't perfect, but is a bit less funky than TreeTime's behavior of placing root exactly on the specified tip. Also, I added You can see resulting output here: |
Member
|
@j23414: Could you add MG812675 to the example data? This should make the CI complete. |
Contributor
Author
trvrb
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Switch to the RefSeq reference 'Josiah' for consistency.
Related issue(s)
Checklist