Use accession for node name but display strain

[jameshadfield]

This is a companion commit to changes in Auspice nextstrain/auspice#1668 which allow any node-attr to be used as the tip label and which displays this tip label in the node hover/click boxes as well as alongside nodes (at suitable zoom levels). This allows us to drop the set_final_strain_name script and ensures all node names are unique which improves the behaviour of Auspice

This commit only changes the Nextstrain datasets, not the Nextclade ones

When viewed on a version of Auspice without the companion changes an error is printed to the console "Invalid JSON-defined tip label: strain" and we fall back to using the node.name (accession) as the tip label.

Testing datasets available at:

• clade-IIb current Nextstrain, new Auspice
• clade-I current Nextstrain, new Auspice
• all-clades current Nextstrain, new Auspice

[joverlee521]

I think we just forgot to merge this after the Auspice feature was released?
Resolves #132

[jameshadfield]

I think we just forgot to merge this after the Auspice feature was released?

Yeah - definitely an element of forgetting, but I am also hesitant to push through PRs in repos like mpox as I don't consider myself to be one of the leaders of the repo. Are you comfortable getting this merged or would you like me to rebase it / re-test it?

[joverlee521]

Yeah - definitely an element of forgetting, but I am also hesitant to push through PRs in repos like mpox as I don't consider myself to be one of the leaders of the repo. Are you comfortable getting this merged or would you like me to rebase it / re-test it?

Probably best to rebase + re-test it since it's been a while 😄

[jameshadfield]

Probably best to rebase + re-test it since it's been a while

Ok - will do - when that's done are you happy to review & merge it, or are there others who should do that part?

[joverlee521]

Ok - will do - when that's done are you happy to review & merge it, or are there others who should do that part?

I'm happy to review and merge it. (I'd say anyone should feel empowered to review here, especially since it doesn't really affect the scientific analysis)

[jameshadfield]

Rebased onto master. Summary of changes this PR effects:

	Master	This PR
node.name	strain name [1]	accession
node.node_attrs.accession	accession	(unchanged)
node.node_attrs.strain	N/A	strain name [2]

The tip name (hover/click boxes, tips displayed on tree etc) was [1] and is now [2] which is set via a display_default in the auspice config.

[joverlee521]

Thanks for rebasing and fixing this up @jameshadfield! Changes LGTM and the CI produced build looks as expected in auspice.us.

I'm not familiar with the INRB build, but do you need to make the same changes to the INRB auspice_config?