NXcsg and NXquadric: promote to base classes - #1648
Draft
woutdenolf wants to merge 2 commits into
Draft
Conversation
woutdenolf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1639 for the details.
What: describes 3D solid geometry using Constructive Solid Geometry (CSG).
Note
NIAC2018 decided to postpone the promotion.
#627 happened one day before the NIAC2018 meeting.
Note
Previous promotion attempt in 2025 by @mkuehbach was deferred for
(1) release-scoping reasons and
(2) not yet used in an application definition.
2025-01-13 (@mkuehbach): "I suggest to keep them in this slightly edited style. Going further, I propose here also to promote them to base classes as they have been sitting in contributed too long"
2025-03-07 (@mkuehbach): feedback implemented, requests telco discussion/vote
2025-07-07 (@phyy-nx): "From Telco: keep these in contributed definitions. Won't require a vote, just an approval."
2025-09-16 (@phyy-nx): "these contributed classes represent features not yet used in an application definition, therefore for simplicity for this release we decided to delay moving them"
Caution
NXcsg does not actually use NXquadric.
I would expect nesting NXquadric directly as a child group of the leaf NXcsg node instead of a string path.
In HDF5 we can use softlinks if needed.