Skip to content

Polish pr#158

Merged
apeltzer merged 4 commits intonf-core:ar_optionalfrom
apeltzer:polish_pr
Mar 4, 2019
Merged

Polish pr#158
apeltzer merged 4 commits intonf-core:ar_optionalfrom
apeltzer:polish_pr

Conversation

@apeltzer
Copy link
Copy Markdown
Member

@apeltzer apeltzer commented Mar 4, 2019

Many thanks to contributing to nf-core/eager!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@apeltzer apeltzer merged commit e83fcf9 into nf-core:ar_optional Mar 4, 2019
@apeltzer apeltzer deleted the polish_pr branch March 4, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant