Skip to content

Damageprofiler yaxis#351

Merged
jfy133 merged 8 commits intonf-core:devfrom
jfy133:damageprofiler-yaxis
Feb 14, 2020
Merged

Damageprofiler yaxis#351
jfy133 merged 8 commits intonf-core:devfrom
jfy133:damageprofiler-yaxis

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Feb 10, 2020

Simply adds an additional parameter (and default) for DamageProfiler to close #336

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

@jfy133 jfy133 requested review from apeltzer and maxibor February 10, 2020 14:53
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Feb 11, 2020

This is crashing due to nextflow-io/nextflow#1491

But will be fixed in the next NF release, so will re-run checks then.

@jfy133 jfy133 self-assigned this Feb 13, 2020
@jfy133 jfy133 linked an issue Feb 13, 2020 that may be closed by this pull request
nextflow doesn't like double dashes in run names for some reason. This would occur when there was a PR from a fork rather than a branch.
@jfy133 jfy133 added the enhancement New feature or request label Feb 13, 2020
@jfy133 jfy133 merged commit 9077aab into nf-core:dev Feb 14, 2020
@jfy133 jfy133 deleted the damageprofiler-yaxis branch March 18, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to fix y-axis on DamageProfiler

2 participants