Add back fully-qualified registry URIs#11251
Merged
ewels merged 2 commits intonf-core:masterfrom Apr 22, 2026
Merged
Conversation
Member
Author
|
pinin4fjords
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Nextflow v25.10 introduced a new config option
docker.registryOverride. This allows folks to use their own mirrors of nf-core module containers.We have had a workaround for a while now where all modules don't include their host and fall back to the default
docker.registrythat is set in the pipeline config, allowing people to configure mirrors withdocker.registry. Now that we havedocker.registryOverridethis workaround is not needed.It's better to have modules self-sufficient (not requiring a pipeline-level config attribute), so this PR goes back to how we used to do it with fully qualified URIs for all
containerattributes.docker.registryshould be ignored if a fully qualified URI is found (this already happens for Seqera Container URIs), so this should not be a breaking change. In the future, we can removedocker.registryfrom the pipeline config, but it's not required.Non-standard containers
In doing this work, I uncovered a few modules that have non-standard containers. Thought I'd list here just in case any are worth following up.
nvcr.io/nvidia— 1 image(s), 12 module reference(s)nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1nvcr.io/nvidia/clara/clara-parabricks:4.6.0-1ghcr.io/schapirolabor— 8 image(s), 8 module reference(s)ghcr.io/schapirolabor/background_subtraction:v0.5.1ghcr.io/schapirolabor/mcmicro-celesta:v0.0.2ghcr.io/schapirolabor/imc2mc:0.0.3ghcr.io/schapirolabor/imc2mc:0.0.2ghcr.io/schapirolabor/macsima2mc:v1.2.15ghcr.io/schapirolabor/phenoimager2mc:v0.2.2ghcr.io/schapirolabor/molkart-local:v0.1.1ghcr.io/schapirolabor/phenoimager2mc:v0.3.2docker.io/google— 3 image(s), 7 module reference(s)docker.io/google/deepsomatic:1.7.0docker.io/google/deepvariant:1.9.0docker.io/google/deepvariant:1.9.0docker.io/google/deepvariant:1.9.0docker.io/google/deepvariant:1.9.0docker.io/google/deepvariant:1.10.0docker.io/google/deepvariant:1.10.0docker.io/biocontainers— 3 image(s), 5 module reference(s)docker.io/biocontainers/diann:v1.8.1_cv1docker.io/biocontainers/diann:v1.8.1_cv1docker.io/biocontainers/ilastik:1.4.0_cv1docker.io/biocontainers/ilastik:1.4.0_cv1docker.io/biocontainers/ncbi-tools-bin:6.1.20170106-6-deb_cv2docker.io/labsyspharm— 3 image(s), 3 module reference(s)docker.io/labsyspharm/basicpy-docker-mcmicro:1.2.0-patch5docker.io/labsyspharm/unetcoreograph:2.2.9docker.io/labsyspharm/scimap:2.1.3quay.io/khersameesh24— 1 image(s), 3 module reference(s)quay.io/khersameesh24/opt:v0.0.1quay.io/khersameesh24/opt:v0.0.1quay.io/khersameesh24/opt:v0.0.1docker.io/ncbi— 2 image(s), 2 module reference(s)docker.io/ncbi/fcs-adaptor:0.5.0docker.io/ncbi/fcs-gx:0.4.0ghcr.io/marcelauliano— 1 image(s), 2 module reference(s)ghcr.io/marcelauliano/mitohifi:3.2.3ghcr.io/marcelauliano/mitohifi:3.2.3https://ftp.ncbi.nlm.nih.gov— 2 image(s), 2 module reference(s)https://ftp.ncbi.nlm.nih.gov/genomes/TOOLS/FCS/releases/0.5.0/fcs-adaptor.sifhttps://ftp.ncbi.nlm.nih.gov/genomes/TOOLS/FCS/releases/0.4.0/fcs-gx.sifdocker.io/clinicalgenomics— 1 image(s), 1 module reference(s)docker.io/clinicalgenomics/cadd-with-scripts:1.7.3docker.io/elembio— 1 image(s), 1 module reference(s)docker.io/elembio/bases2fastq:2.3.0docker.io/felbecker— 1 image(s), 1 module reference(s)docker.io/felbecker/learnmsa:2.0.14docker.io/hkubal— 1 image(s), 1 module reference(s)docker.io/hkubal/clair3:v2.0.0docker.io/miguelib— 1 image(s), 1 module reference(s)docker.io/miguelib/scimap:0.0.3docker.io/teambraker— 1 image(s), 1 module reference(s)docker.io/teambraker/braker3:v3.0.7.5ghcr.io/nbisweden— 1 image(s), 1 module reference(s)ghcr.io/nbisweden/fastk_genescopefk_merquryfk:1.2ghcr.io/scverse— 1 image(s), 1 module reference(s)ghcr.io/scverse/scvi-tools:py3.12-cu12-1.3.3-us.gcr.io/broad-dsde-methods— 1 image(s), 1 module reference(s)us.gcr.io/broad-dsde-methods/cellbender:0.3.2