Add stub block and migrate emmtyper to topic channels#11377
Merged
HReed1 merged 7 commits intonf-core:masterfrom Apr 29, 2026
Merged
Add stub block and migrate emmtyper to topic channels#11377HReed1 merged 7 commits intonf-core:masterfrom
HReed1 merged 7 commits intonf-core:masterfrom
Conversation
- Replace versions.yml HEREDOC with tuple/eval/topic output - Add stub block with touch for TSV output - Update meta.yml with versions_emmtyper output and topics block - Add stub test to main.nf.test Addresses nf-core#4570 and nf-core#10832
Regenerated via: nf-core modules test emmtyper --update --profile docker - Updated test-emmtyper snapshot: versions.yml → tuple [EMMTYPER, emmtyper, 0.2.0] - Created test-emmtyper-stub snapshot - nf-test 0.9.5 / Nextflow 25.10.4
12 tasks
Contributor
|
I'm not sure why conda tests are failing when docker and singularity look fine, the error appears to be in the version check |
- Use single-quoted eval() with direct pipe to prevent Conda CI bash syntax errors from Python traceback parentheses - Add sanitizeOutput() wrapper per nft-utils convention - Regenerate snapshots with sanitized output format Fixes conda CI failure reported by @heuermh Addresses test convention feedback from @famosab
Contributor
Author
|
Thanks for flagging this @heuermh! The issue was the Fixed in the latest push: switched to single-quoted |
5 tasks
SPPearce
reviewed
Apr 29, 2026
Remove echo $() wrapper from meta.yml version expressions to match the corrected single-quoted eval() pattern in main.nf. Addresses review comment from @SPPearce.
- Switch eval() from CLI --version to python -c import pattern for robustness across Docker and Conda environments - Use prettier-compatible YAML quoting in meta.yml - Passes: nf-core lint (53/53), prettier --check, nf-test (stable) Co-authored-by: Seqera AI <ai@seqera.io>
Contributor
Author
|
Thank you @SPPearce for all the feedback. We are current Green on all Github Actions for this PR. |
mribeirodantas
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
emmtypermodule to use topic channels for version outputs and adds a stub block, addressing both #4570 and #11389.This is a pilot PR to validate the combined stubs + topics migration pattern before batch-submitting the remaining ~39 modules.
Changes
main.nfpath "versions.yml", emit: versionswith single-quotedeval()topic output:cat <<-END_VERSIONSHEREDOC block from the scriptstub:block withtouch ${prefix}.tsvmeta.yml(auto-fixed vianf-core modules lint --fix)versions:output (versions.yml file) withversions_emmtyper:tuple definitiontopics:block below outputstests/main.nf.testtest("test-emmtyper - stub")withoptions "-stub"sanitizeOutput(process.out)per nft-utils conventionValidation
nf-core modules lint emmtyper→ 51/51 passed, 0 warnings, 0 failuresnf-core modules test emmtyper --update --profile docker→ All tests passed, snapshots stablePR checklist
Closes #4570 (partial — emmtyper only)
Related to #10832
topic: versions- See version_topicslabelnf-core modules test emmtyper --profile dockernf-core modules test emmtyper --profile singularitynf-core modules test emmtyper --profile conda