Skip to content

Add ldak/thinpredictors module#12293

Merged
lyh970817 merged 4 commits into
nf-core:masterfrom
lyh970817:ldak-thinpredictors
Jul 10, 2026
Merged

Add ldak/thinpredictors module#12293
lyh970817 merged 4 commits into
nf-core:masterfrom
lyh970817:ldak-thinpredictors

Conversation

@lyh970817

Copy link
Copy Markdown
Contributor

PR checklist

This PR adds the ldak/thinpredictors module. It runs LDAK (ldak6 --thin) to perform linkage-disequilibrium pruning on a PLINK binary fileset (bed/bim/fam) and emit a thinned predictor list, which downstream LDAK steps use to build weighted kinship matrices. It upstreams main.nf, meta.yml, environment.yml, and nf-test tests (including a stub), with topic-based version reporting. Tests reuse the existing public plink_simulated fixtures from nf-core/test-datasets; no new test data required.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR (not necessary — reuses existing plink_simulated fixtures).
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test ldak/thinpredictors --profile docker
      • nf-core modules test ldak/thinpredictors --profile singularity
      • nf-core modules test ldak/thinpredictors --profile conda

Primary module: ldak/thinpredictors. Bundled test-dependency modules: (none).
Ported and reorganised from the LDAK module family (nf-core naming, fixed
container/version/contract issues).

@chriswyatt1 chriswyatt1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, checked through that, and it all looks correct.
Are we sure process_medium is the best generic setting to use?

@chriswyatt1

Copy link
Copy Markdown
Contributor

Actually
Before we merge, what about bed and bim?

@chriswyatt1 chriswyatt1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to solve where bed and bim are used in the module.

Ah sorry, just worked out that the names are implicit, so they are being used.

@chriswyatt1 chriswyatt1 dismissed their stale review July 9, 2026 09:17

This is not an issue, they are being used in the script

@lyh970817

Copy link
Copy Markdown
Contributor Author

Great, checked through that, and it all looks correct. Are we sure process_medium is the best generic setting to use?

I think process_medium is fine for this module but honestly I've been using it as a generic placeholder... I'll replace with more sensible settings for other modules - some do deserve process_high.

Comment thread modules/nf-core/ldak/thinpredictors/main.nf Outdated
Comment thread modules/nf-core/ldak/thinpredictors/main.nf Outdated
Comment thread modules/nf-core/ldak/thinpredictors/meta.yml
Comment thread modules/nf-core/ldak/thinpredictors/tests/main.nf.test Outdated
@lyh970817 lyh970817 requested a review from SPPearce July 10, 2026 03:43
@lyh970817 lyh970817 added this pull request to the merge queue Jul 10, 2026
Merged via the queue into nf-core:master with commit ded3e7e Jul 10, 2026
79 checks passed
@lyh970817 lyh970817 deleted the ldak-thinpredictors branch July 10, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants