Skip to content

Migrate ngmaster versions to topic channel#12414

Merged
xHaMMaDy merged 7 commits into
nf-core:masterfrom
xHaMMaDy:ngmaster_topics_migration
Jul 26, 2026
Merged

Migrate ngmaster versions to topic channel#12414
xHaMMaDy merged 7 commits into
nf-core:masterfrom
xHaMMaDy:ngmaster_topics_migration

Conversation

@xHaMMaDy

Copy link
Copy Markdown
Contributor

Summary

  • migrate NGMASTER version reporting from versions.yml to the versions topic
  • document the version tuple in meta.yml
  • update nf-test snapshots
  • handle ngmaster warnings consistently across execution profiles

Closes #12322

Tests

  • Docker
  • Singularity
  • Conda
  • Nextflow lint

@xHaMMaDy
xHaMMaDy marked this pull request as ready for review July 23, 2026 13:30
Copilot AI review requested due to automatic review settings July 23, 2026 13:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ngmaster nf-core module to publish tool version information via the versions topic (as a version tuple) instead of writing a versions.yml file, and aligns the module metadata and nf-test snapshots with that change.

Changes:

  • Replace versions.yml generation with a versions_ngmaster tuple output published to the versions topic.
  • Document the version tuple structure in meta.yml (both as a module output and under the versions topic).
  • Update nf-test snapshots to reflect the new versions reporting format.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
modules/nf-core/ngmaster/main.nf Removes versions.yml creation and emits a versions_ngmaster tuple to the versions topic.
modules/nf-core/ngmaster/meta.yml Documents the new versions_ngmaster tuple output and the versions topic payload shape.
modules/nf-core/ngmaster/tests/main.nf.test.snap Updates snapshots to match the new tuple-based versions reporting and updated test/runtime metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mashehu mashehu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please join the github org via the slack channel so the CI runs for you.

Comment thread modules/nf-core/ngmaster/main.nf Outdated
@xHaMMaDy
xHaMMaDy enabled auto-merge July 23, 2026 14:33
@xHaMMaDy
xHaMMaDy force-pushed the ngmaster_topics_migration branch from d38fa5a to 7528f0a Compare July 24, 2026 12:32
@xHaMMaDy
xHaMMaDy added this pull request to the merge queue Jul 26, 2026
Merged via the queue into nf-core:master with commit bea6686 Jul 26, 2026
23 checks passed
@xHaMMaDy
xHaMMaDy deleted the ngmaster_topics_migration branch July 26, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to topic ngmaster

4 participants