Migrate ngmaster versions to topic channel#12414
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ngmaster nf-core module to publish tool version information via the versions topic (as a version tuple) instead of writing a versions.yml file, and aligns the module metadata and nf-test snapshots with that change.
Changes:
- Replace
versions.ymlgeneration with aversions_ngmastertuple output published to theversionstopic. - Document the version tuple structure in
meta.yml(both as a module output and under theversionstopic). - Update nf-test snapshots to reflect the new versions reporting format.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/nf-core/ngmaster/main.nf | Removes versions.yml creation and emits a versions_ngmaster tuple to the versions topic. |
| modules/nf-core/ngmaster/meta.yml | Documents the new versions_ngmaster tuple output and the versions topic payload shape. |
| modules/nf-core/ngmaster/tests/main.nf.test.snap | Updates snapshots to match the new tuple-based versions reporting and updated test/runtime metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mashehu
reviewed
Jul 23, 2026
mashehu
left a comment
Contributor
There was a problem hiding this comment.
Please join the github org via the slack channel so the CI runs for you.
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
xHaMMaDy
enabled auto-merge
July 23, 2026 14:33
xHaMMaDy
force-pushed
the
ngmaster_topics_migration
branch
from
July 24, 2026 12:32
d38fa5a to
7528f0a
Compare
SPPearce
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versions.ymlto theversionstopicmeta.ymlCloses #12322
Tests