Skip to content

canvas/germline: Added tests and missing inputs, some cleanup - #12462

Open
Schmytzi wants to merge 11 commits into
nf-core:masterfrom
Schmytzi:canvas_cleanup
Open

canvas/germline: Added tests and missing inputs, some cleanup#12462
Schmytzi wants to merge 11 commits into
nf-core:masterfrom
Schmytzi:canvas_cleanup

Conversation

@Schmytzi

@Schmytzi Schmytzi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • Added missing inputs and tests.
  • Replaced genomedir input with separate kmer_fasta and genomesize inputs
  • Removed automatic selection of ploidy VCF based on sex, now responsibility of the caller
  • Removed dependency on external python script
  • Replaced file operations on inputs with stageAs
  • Added check that at least one SNV VCF is supplied
  • Removed automatic filtering of REF calls, now responsibility of the caller
  • Replaced hard-coded version with call to Canvas --version
  • Skipping CI tests because of hard-coded request for 8 CPUs and 25 GB of RAM

Requires nf-core/test-datasets#2188 to be merged first.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@Schmytzi
Schmytzi marked this pull request as ready for review August 6, 2026 09:15
@Schmytzi
Schmytzi requested review from a team as code owners August 6, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant