Skip to content

Created fcs subworkflow#3477

Merged
scorreard merged 9 commits into
nf-core:masterfrom
scorreard:fasta_clean_fcs
Jun 2, 2023
Merged

Created fcs subworkflow#3477
scorreard merged 9 commits into
nf-core:masterfrom
scorreard:fasta_clean_fcs

Conversation

@scorreard
Copy link
Copy Markdown
Contributor

@scorreard scorreard commented Jun 1, 2023

PR checklist

Closes nf-core/genomeassembler issue 41nf-core/genomeassembler#41

  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@scorreard
Copy link
Copy Markdown
Contributor Author

This is my first subworkflow, and I will likely create a bunch after that, so let me know anything that can be improved so that the next ones are 👌👌

@scorreard scorreard self-assigned this Jun 1, 2023
@scorreard
Copy link
Copy Markdown
Contributor Author

scorreard commented Jun 2, 2023

Answer to conda failure : Those tools don't have conda env, which explains the failed conda

@scorreard
Copy link
Copy Markdown
Contributor Author

scorreard commented Jun 2, 2023

Answer to docker failure : Docker works when running the test on GitPod, I don't really know why it fails here

image

@scorreard scorreard added Ready for Review and removed WIP Work in progress labels Jun 2, 2023
@scorreard scorreard requested review from d4straub and removed request for d4straub June 2, 2023 13:55
@scorreard
Copy link
Copy Markdown
Contributor Author

suggesting @d4straub as a reviewer as you wrote both modules

@maxulysse
Copy link
Copy Markdown
Member

maxulysse commented Jun 2, 2023

Answer to conda failure : Those tools don't have conda env, which explains the failed conda

You can remove conda from the tests.

Add it there:

- profile: "conda"
tags: annotsv
- profile: "conda"
tags: cellpose
- profile: "conda"
tags: mcquant
- profile: "conda"
tags: bases2fastq
- profile: "conda"
tags: backsub
- profile: "conda"
tags: basicpy
- profile: "conda"
tags: bcl2fastq
- profile: "conda"
tags: bclconvert
- profile: "conda"
tags: cellranger/count
- profile: "conda"
tags: cellranger/mkfastq
- profile: "conda"
tags: cellranger/mkgtf
- profile: "conda"
tags: cellranger/mkref
- profile: "conda"
tags: cellranger/mkvdjref
- profile: "conda"
tags: cellranger/multi
- profile: "conda"
tags: cellranger/vdj
- profile: "conda"
tags: coreograph
- profile: "conda"
tags: deepcell/mesmer
- profile: "conda"
tags: deepvariant
- profile: "conda"
tags: ensemblvep/vep
- profile: "conda"
tags: fastk/fastk
- profile: "conda"
tags: fastk/histex
- profile: "conda"
tags: fastk/merge
- profile: "conda"
tags: fcs/fcsadaptor
- profile: "conda"
tags: fcs/fcsgx
- profile: "conda"
tags: gatk4/baserecalibratorspark
- profile: "conda"
tags: gatk4/cnnscorevariants
- profile: "conda"
tags: gatk4/determinegermlinecontigploidy
- profile: "conda"
tags: gatk4/germlinecnvcaller
- profile: "conda"
tags: gatk4/markduplicatesspark
- profile: "conda"
tags: gatk4/postprocessgermlinecnvcalls
- profile: "conda"
tags: genescopefk
- profile: "conda"
tags: ilastik/multicut
- profile: "conda"
tags: ilastik/pixelclassification
- profile: "conda"
tags: imputeme/vcftoprs
- profile: "conda"
tags: merquryfk/katcomp
- profile: "conda"
tags: merquryfk/katgc
- profile: "conda"
tags: merquryfk/merquryfk
- profile: "conda"
tags: merquryfk/ploidyplot
- profile: "conda"
tags: mitohifi/findmitoreference
- profile: "conda"
tags: scimap/mcmicro
- profile: "conda"
tags: sentieon/applyvarcal
- profile: "conda"
tags: sentieon/bwaindex
- profile: "conda"
tags: sentieon/bwamem
- profile: "conda"
tags: sentieon/dedup
- profile: "conda"
tags: sentieon/gvcftyper
- profile: "conda"
tags: sentieon/haplotyper
- profile: "conda"
tags: sentieon/varcal
- profile: "conda"
tags: universc
- profile: "singularity"
tags: universc
- profile: "singularity"
tags: gatk4/determinegermlinecontigploidy
- profile: "conda"
tags: subworkflows/bcl_demultiplex
- profile: "conda"
tags: subworkflows/vcf_annotate_ensemblvep_snpeff
- profile: "conda"
tags: subworkflows/vcf_annotate_ensemblvep
- profile: "conda"
tags: islandpath

@maxulysse
Copy link
Copy Markdown
Member

@scorreard solve the merged conflicts with the ci file.
We really need to sort this file properly...

@maxulysse
Copy link
Copy Markdown
Member

@scorreard for your docker issues, I think it's coming from something else.
These PRs should fix it:
#3483
#3484

Comment thread .github/workflows/pytest-workflow.yml Outdated
@maxulysse
Copy link
Copy Markdown
Member

Good catch, I opened twice the same PR...
🤦

@scorreard
Copy link
Copy Markdown
Contributor Author

Good catch, I opened twice the same PR...
🤦

I was refreshing the page wondering why it was not working, and then realized that... It's ok, it's Friday!

@scorreard scorreard added this pull request to the merge queue Jun 2, 2023
Merged via the queue into nf-core:master with commit e4eac51 Jun 2, 2023
@scorreard scorreard deleted the fasta_clean_fcs branch June 2, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants