Skip to content

Add checkm/lineagewf nf tests.#5652

Merged
maxulysse merged 7 commits intonf-core:masterfrom
Vivian-chen16:master
May 22, 2024
Merged

Add checkm/lineagewf nf tests.#5652
maxulysse merged 7 commits intonf-core:masterfrom
Vivian-chen16:master

Conversation

@Vivian-chen16
Copy link
Copy Markdown
Contributor

PR checklist

Closes #5650

@SPPearce
Copy link
Copy Markdown
Contributor

Looks like there are quite a few files that are changing every time, do they have a timestamp in them?
You also need to remove the pytest files from tests/modules/nf-core/checkm/lineagewf(and the entry in tests/config/pytest_modules.yml).

@Vivian-chen16 Vivian-chen16 requested review from a team and LeuThrAsp and removed request for a team May 22, 2024 19:21
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a stub test too please.
If the module doesn't already have a stub, then please add one ;)

Comment thread modules/nf-core/checkm/lineagewf/tests/main.nf.test Outdated
Comment thread modules/nf-core/checkm/lineagewf/tests/main.nf.test Outdated
Comment thread modules/nf-core/checkm/lineagewf/tests/main.nf.test Outdated
Comment thread modules/nf-core/checkm/lineagewf/tests/main.nf.test Outdated
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@maxulysse maxulysse enabled auto-merge May 22, 2024 20:48
@maxulysse maxulysse added this pull request to the merge queue May 22, 2024
Merged via the queue into nf-core:master with commit 5238da4 May 22, 2024
tstoeriko pushed a commit to tstoeriko/nf-core-modules that referenced this pull request May 23, 2024
* Add checkm/lineagewf nf tests.

* Remove files contain timestamp from snapshot

* Remove pytest files

* Delete checkm_lineagewf entry in pytest_modules.yml

* Apply suggestions from code review

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>

---------

Co-authored-by: Wei-An Chen <wchen@VEDANTABIO.COM>
Co-authored-by: Sateesh_Peri <33637490+sateeshperi@users.noreply.github.com>
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

nf test for checkm_lineagewf

5 participants