Skip to content

Unify windowmasker config#8027

Merged
mahesh-panchal merged 1 commit intonf-core:masterfrom
mahesh-panchal:unify_windowmasker_config
Mar 25, 2025
Merged

Unify windowmasker config#8027
mahesh-panchal merged 1 commit intonf-core:masterfrom
mahesh-panchal:unify_windowmasker_config

Conversation

@mahesh-panchal
Copy link
Copy Markdown
Member

@mahesh-panchal mahesh-panchal commented Mar 25, 2025

PR checklist

Unifies the windowmasker config to follow module guidelines: https://nf-co.re/docs/guidelines/components/modules#configuration-of-extargs-in-tests

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mahesh-panchal mahesh-panchal marked this pull request as ready for review March 25, 2025 11:04
@DLBPointon
Copy link
Copy Markdown
Contributor

Nice tidying up, thanks Mahesh.

Looks good to me!

@mahesh-panchal mahesh-panchal added this pull request to the merge queue Mar 25, 2025
Merged via the queue into nf-core:master with commit 3eec62b Mar 25, 2025
25 checks passed
@mahesh-panchal mahesh-panchal deleted the unify_windowmasker_config branch March 25, 2025 17:55
olgabot pushed a commit that referenced this pull request Mar 25, 2025
zachary-foster pushed a commit to zachary-foster/modules that referenced this pull request Mar 27, 2025
Dewey-Wang pushed a commit to Dewey-Wang/modules that referenced this pull request Mar 28, 2025
famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants