Skip to content

Conversation

@leomrtns
Copy link
Contributor

@leomrtns leomrtns commented Mar 19, 2024

If GITHUB_TOKEN exists but it's incorrect, then nf-core download will raise RuntimeError(). Previously it was not catching 401 (unauthorised) response status, and unrelated errors occurred downstream.

I tested its behaviour with GITHUB_TOKEN="bububbub" nf-core --verbose download ampliseq

I hope this is enough, please let me know if there is anything else I must do.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.87%. Comparing base (a6c2808) to head (738323b).

❗ Current head 738323b differs from pull request most recent head 81d5509. Consider uploading reports for the commit 81d5509 to get more accurate results

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thanhleviet thanhleviet merged commit 8633f85 into dev Mar 19, 2024
@thanhleviet thanhleviet deleted the mesg_unauthorised__download_fail branch March 19, 2024 16:24
@ewels
Copy link
Member

ewels commented Mar 20, 2024

Merged with failing tests 😞 CI is now ❌ on master and all PRs..

@thanhleviet / @leomrtns / @mashehu can someone take a look ASAP please?

@mashehu
Copy link
Contributor

mashehu commented Mar 20, 2024

fixed in #2885

@leomrtns leomrtns self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants