-
Notifications
You must be signed in to change notification settings - Fork 62
[ENH] yapf-ify code + add .gitignore #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This relates to #12 (comment) Adding the |
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
======================================
Coverage 76.4% 76.4%
======================================
Files 6 6
Lines 856 856
Branches 228 228
======================================
Hits 654 654
Misses 141 141
Partials 61 61
Continue to review full report at Codecov.
|
| @@ -1,4 +1,3 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we exclude this from yapf? This is an auto-generated file.
|
when merged, can these commits please be squashed? |
|
Is this ready to add a flake8 check in Travis? I think we might need #14 first. |
This PR proposes:
.style.yapffile and updating the code according toyapf.gitignorefileThe
.style.yapffile is an explicit listing of pep8 style. The changes thatyapfmade are reasonable, but please let me know if you don't like any of the style.to run
yapf, I ran this on the command line:This will change files in-place and in parallel.